VReplication: Set time zone to UTC while streaming rows #6845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit-nayak-ps
changed the title
rohit-nayak-ps
requested review from
harshit-gangal,
shlomi-noach,
sougou and
systay
as code owners
shlomi-noach
approved these changes
Oct 15, 2020
harshit-gangal
approved these changes
Oct 20, 2020
|
@rohit-nayak-ps we should also port this over to release-8.0, correct? |
sougou
approved these changes
Oct 22, 2020
|
Can be merged after conflicts are resolved. |
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…timestamps Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
force-pushed
the
rn-rowstreamer-set-tz-utc
branch
from
76a6417
to
c15e4b0
Compare
Merged
deepthi
added a commit
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we set the timezone of the mysql connection to be UTC while replicating. However during the copy phase it is still using the default timezone. This causes columns of the timestamp datatype to be incorrect on the target.
Signed-off-by: Rohit Nayak rohit@planetscale.com